Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-2433

SqlAdvisor.getCompletionHints is hard-coded for " quoting

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.17.0
    • 1.18.0
    • core
    • None

    Description

      Relevant source:

          boolean quoted = false;
    while (wordStart > 0
        && Character.isJavaIdentifierPart(sql.charAt(wordStart - 1))) {
      --wordStart;
    }
    if ((wordStart > 0)
        && (sql.charAt(wordStart - 1) == '"')) { // <-- It should get quoting from the connection
      quoted = true;
      --wordStart;
    }

      Attachments

        Issue Links

          duplicates

          Improvement - An improvement or enhancement to an existing feature or task. CALCITE-152 SqlAdvisor should honor quoting rules

          • Major - Major loss of function.
          • Closed
          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. CALCITE-2435 Refactor SqlTestFactory

          • Major - Major loss of function.
          • Closed

          Activity

            People

              julianhyde Julian Hyde
              vladimirsitnikov Vladimir Sitnikov
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: